Ignore a set of SWC-123 warnings,

2 of those are false positives reported with following issue Logged Consensys/truffle-security#224 The rest are valid ignores.
JoinColony · Jul 23, 2019 · 57992f3 · 57992f3
1 parent be8896a
commit 57992f3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/contracts/ContractRecovery.sol b/contracts/ContractRecovery.sol
@@ -25,7 +25,7 @@ import "./IRecovery.sol";
 
 /// @title Used for recovery in both ColonyNetwork and Colony instances
 /// @notice Implements functions defined in IRecovery interface
-contract ContractRecovery is CommonStorage {
+contract ContractRecovery is CommonStorage { // ignore-swc-123
   uint8 constant RECOVERY_ROLE = uint8(ColonyDataTypes.ColonyRole.Recovery);
 
   event RecoveryRoleSet(address indexed user, bool setTo);
@@ -36,7 +36,7 @@ contract ContractRecovery is CommonStorage {
     require(_slot != RESOLVER_SLOT, "colony-common-protected-variable");
 
     // NB. This isn't necessarily a colony - could be ColonyNetwork. But they both have this function, so it's okay.
-    IRecovery(address(this)).checkNotAdditionalProtectedVariable(_slot);
+    IRecovery(address(this)).checkNotAdditionalProtectedVariable(_slot); // ignore-swc-123
 
     // Protect key variables
     uint64 _recoveryRolesCount = recoveryRolesCount;

diff --git a/contracts/extensions/OldRolesFactory.sol b/contracts/extensions/OldRolesFactory.sol
@@ -25,19 +25,19 @@ import "./ExtensionFactory.sol";
 import "./OldRoles.sol";
 
 
-contract OldRolesFactory is ExtensionFactory, ColonyDataTypes { // ignore-swc-123. TODO Any takers to explain to me?
+contract OldRolesFactory is ExtensionFactory, ColonyDataTypes { // ignore-swc-123
   mapping (address => OldRoles) public deployedExtensions;
 
   function deployExtension(address _colony) external {
-    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root");
+    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root"); // ignore-swc-123
     require(deployedExtensions[_colony] == OldRoles(0x00), "colony-extension-already-deployed");
     OldRoles newExtensionAddress = new OldRoles(_colony);
     deployedExtensions[_colony] = newExtensionAddress;
     emit ExtensionDeployed("OldRoles", _colony, address(newExtensionAddress));
   }
 
   function removeExtension(address _colony) external {
-    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root");
+    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root"); // ignore-swc-123
     deployedExtensions[_colony] = OldRoles(0x00);
     emit ExtensionRemoved("OldRoles", _colony);
   }

diff --git a/contracts/extensions/OneTxPaymentFactory.sol b/contracts/extensions/OneTxPaymentFactory.sol
@@ -29,7 +29,7 @@ contract OneTxPaymentFactory is ExtensionFactory, ColonyDataTypes { // ignore-sw
   mapping (address => OneTxPayment) public deployedExtensions;
 
   function deployExtension(address _colony) external {
-    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root");
+    require(IColony(_colony).hasUserRole(msg.sender, 1, ColonyRole.Root), "colony-extension-user-not-root"); // ignore-swc-123
     require(deployedExtensions[_colony] == OneTxPayment(0x00), "colony-extension-already-deployed");
     OneTxPayment newExtensionAddress = new OneTxPayment(_colony);
     deployedExtensions[_colony] = newExtensionAddress;