Increase branch coverage on extension tests

JoinColony · Jun 7, 2022 · 51daa24 · 51daa24
1 parent 632b7cc
commit 51daa24
Show file tree

Hide file tree

Showing 7 changed files with 42 additions and 10 deletions.
diff --git a/test/extensions/expenditure-utils.js b/test/extensions/expenditure-utils.js
@@ -123,10 +123,8 @@ contract("ExpenditureUtils", (accounts) => {
       expect(code).to.equal("0x");
     });
 
-    it("cannot manage the extension if not owner", async () => {
-      expenditureUtils = await ExpenditureUtils.new();
-
-      await checkErrorRevert(expenditureUtils.install(colony.address, { from: USER1 }), "ds-auth-unauthorized");
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      await checkErrorRevert(expenditureUtils.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
       await checkErrorRevert(expenditureUtils.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
       await checkErrorRevert(expenditureUtils.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
       await checkErrorRevert(expenditureUtils.uninstall({ from: USER1 }), "ds-auth-unauthorized");

diff --git a/test/extensions/funding-queue.js b/test/extensions/funding-queue.js
@@ -6,7 +6,7 @@ const bnChai = require("bn-chai");
 const { ethers } = require("ethers");
 const { soliditySha3 } = require("web3-utils");
 
-const { UINT256_MAX, WAD, MINING_CYCLE_DURATION, SECONDS_PER_DAY, CHALLENGE_RESPONSE_WINDOW_DURATION } = require("../../helpers/constants");
+const { UINT256_MAX, WAD, MINING_CYCLE_DURATION, SECONDS_PER_DAY, CHALLENGE_RESPONSE_WINDOW_DURATION, ADDRESS_ZERO } = require("../../helpers/constants");
 
 const {
   checkErrorRevert,
@@ -196,6 +196,13 @@ contract("Funding Queues", (accounts) => {
 
       await colony.uninstallExtension(FUNDING_QUEUE, { from: USER0 });
     });
+
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      await checkErrorRevert(fundingQueue.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(fundingQueue.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(fundingQueue.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(fundingQueue.uninstall({ from: USER1 }), "ds-auth-unauthorized");
+    });
   });
 
   describe("creating funding proposals", async () => {

diff --git a/test/extensions/one-tx-payment.js b/test/extensions/one-tx-payment.js
@@ -5,7 +5,7 @@ const bnChai = require("bn-chai");
 const { ethers } = require("ethers");
 const { soliditySha3 } = require("web3-utils");
 
-const { UINT256_MAX, WAD, INITIAL_FUNDING, GLOBAL_SKILL_ID, FUNDING_ROLE, ADMINISTRATION_ROLE } = require("../../helpers/constants");
+const { UINT256_MAX, WAD, INITIAL_FUNDING, GLOBAL_SKILL_ID, FUNDING_ROLE, ADMINISTRATION_ROLE, ADDRESS_ZERO } = require("../../helpers/constants");
 const { checkErrorRevert, web3GetCode, rolesToBytes32, expectEvent } = require("../../helpers/test-helper");
 const { setupRandomColony, fundColonyWithTokens, getMetaTransactionParameters } = require("../../helpers/test-data-generator");
 
@@ -31,7 +31,6 @@ contract("One transaction payments", (accounts) => {
   const USER2 = accounts[1].toLowerCase() < accounts[2].toLowerCase() ? accounts[2] : accounts[1];
 
   const ROLES = rolesToBytes32([FUNDING_ROLE, ADMINISTRATION_ROLE]);
-  const ADDRESS_ZERO = ethers.constants.AddressZero;
 
   before(async () => {
     const etherRouter = await EtherRouter.deployed();
@@ -89,6 +88,13 @@ contract("One transaction payments", (accounts) => {
 
       await colony.uninstallExtension(ONE_TX_PAYMENT);
     });
+
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      await checkErrorRevert(oneTxPayment.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(oneTxPayment.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(oneTxPayment.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(oneTxPayment.uninstall({ from: USER1 }), "ds-auth-unauthorized");
+    });
   });
 
   describe("using the extension", async () => {

diff --git a/test/extensions/token-supplier.js b/test/extensions/token-supplier.js
@@ -6,7 +6,7 @@ const bnChai = require("bn-chai");
 const { ethers } = require("ethers");
 const { soliditySha3 } = require("web3-utils");
 
-const { UINT256_MAX, WAD, SECONDS_PER_DAY } = require("../../helpers/constants");
+const { UINT256_MAX, WAD, SECONDS_PER_DAY, ADDRESS_ZERO } = require("../../helpers/constants");
 const { setupRandomColony, getMetaTransactionParameters } = require("../../helpers/test-data-generator");
 const { checkErrorRevert, currentBlockTime, makeTxAtTimestamp, getBlockTime, forwardTime } = require("../../helpers/test-helper");
 
@@ -196,6 +196,13 @@ contract("Token Supplier", (accounts) => {
       expect(lastPinged).to.eq.BN(blockTime);
       expect(lastRateUpdate).to.eq.BN(blockTime);
     });
+
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      await checkErrorRevert(tokenSupplier.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(tokenSupplier.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(tokenSupplier.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(tokenSupplier.uninstall({ from: USER1 }), "ds-auth-unauthorized");
+    });
   });
 
   describe("issuing tokens", async () => {

diff --git a/test/extensions/voting-rep.js b/test/extensions/voting-rep.js
@@ -332,6 +332,13 @@ contract("Voting Reputation", (accounts) => {
       expect(revealPeriod).to.eq.BN(REVEAL_PERIOD);
       expect(escalationPeriod).to.eq.BN(ESCALATION_PERIOD);
     });
+
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      // await checkErrorRevert(voting.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(voting.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(voting.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(voting.uninstall({ from: USER1 }), "ds-auth-unauthorized");
+    });
   });
 
   describe("creating motions", async () => {

diff --git a/test/extensions/whitelist.js b/test/extensions/whitelist.js
@@ -5,7 +5,7 @@ const bnChai = require("bn-chai");
 const { ethers } = require("ethers");
 const { soliditySha3 } = require("web3-utils");
 
-const { UINT256_MAX, IPFS_HASH } = require("../../helpers/constants");
+const { UINT256_MAX, IPFS_HASH, ADDRESS_ZERO } = require("../../helpers/constants");
 const { checkErrorRevert, web3GetCode } = require("../../helpers/test-helper");
 const { setupRandomColony, getMetaTransactionParameters } = require("../../helpers/test-data-generator");
 
@@ -76,6 +76,13 @@ contract("Whitelist", (accounts) => {
 
       await colony.uninstallExtension(WHITELIST, { from: USER0 });
     });
+
+    it("can't use the network-level functions if installed via ColonyNetwork", async () => {
+      await checkErrorRevert(whitelist.install(ADDRESS_ZERO, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(whitelist.finishUpgrade({ from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(whitelist.deprecate(true, { from: USER1 }), "ds-auth-unauthorized");
+      await checkErrorRevert(whitelist.uninstall({ from: USER1 }), "ds-auth-unauthorized");
+    });
   });
 
   describe("using the whitelist", async () => {

diff --git a/test/packages/metaTransactionBroadcaster.js b/test/packages/metaTransactionBroadcaster.js
@@ -35,7 +35,7 @@ const loader = new TruffleLoader({
   contractDir: path.resolve(__dirname, "..", "..", "build", "contracts"),
 });
 
-contract("Metatransaction broadcaster", (accounts) => {
+contract.only("Metatransaction broadcaster", (accounts) => {
   const USER0 = accounts[0];
   const USER1 = accounts[1];