Improve docker compatibility #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmanie
force-pushed
the
maintenance/fix-docker-permissions
branch
from
8bb5a92 to
49e475d
Compare
ink-pot-monkey
previously approved these changes
Nov 13, 2023
ArmandoGraterol
previously approved these changes
Nov 13, 2023
chmanie
dismissed stale reviews from ArmandoGraterol and ink-pot-monkey
via
9f1c6c9
chmanie
force-pushed
the
maintenance/fix-docker-permissions
branch
from
49e475d to
9f1c6c9
Compare
arrenv
approved these changes
Nov 14, 2023
ink-pot-monkey
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the compatibility of our docker setup with newer docker versions and tools like podman which in turn enables us to run our setup as non-root users in Linux.
Most importantly the
linksentries were removed from the docker-compose files which is an option that's long deprecated and not necessary anymore.To use with
podmanif you like (rootless, on Linux - DO NOT DO THIS IF YOU'RE ON A MAC OR WINDOWS):podmanin version 4.7.x to support thedocker composecommanddocker-compose(standalone, without docker) orpodman-compose(untested)dnsnameplugin installed and configureddockeraliased topodman(podman-dockermight help)npm run dev, make sure toexport DOCKER_HOST=unix:///run/user/1000/podman/podman.sock(this will be fixed in a future version of podman - Use url with scheme and path for the unix address containers/podman#19917 (comment))