Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev Portal - Designer Edits #44

Merged
merged 34 commits into from
Apr 10, 2019
Merged

Dev Portal - Designer Edits #44

merged 34 commits into from
Apr 10, 2019

Conversation

ceolson01
Copy link
Contributor

@ceolson01 ceolson01 commented Apr 3, 2019 •
edited
Loading

⚠️ The logo for colonyJS is temporarily inaccurate (should be logomark, but instead is currently the regular logo). This is being changed in the appropriate repo.

The contents of this PR are visible on the QA server.

Description

This PR adds edits that have been outlined by design team.

Unchecked items will be handled in another PR, as this one has grown in size.

Contributes to #33

@ceolson01 ceolson01 added bug Something isn't working in-progress labels Apr 3, 2019
@ceolson01 ceolson01 self-assigned this Apr 3, 2019
@ceolson01 ceolson01 mentioned this pull request Apr 4, 2019
Merged
@ceolson01 ceolson01 force-pushed the fix/designer-edits branch from eabbf57 to b77dddf Compare April 4, 2019 01:51
@ceolson01 ceolson01 force-pushed the fix/designer-edits branch from b77dddf to e2f1729 Compare April 4, 2019 15:21
@ceolson01 ceolson01 changed the base branch from feature/22-tutorial-list to master April 4, 2019 15:21
@ceolson01 ceolson01 requested a review from rdig April 9, 2019 18:02
@ceolson01 ceolson01 changed the title Pre-Launch Designer Edits Dev Portal - Designer Edits Apr 9, 2019
@ceolson01 ceolson01 force-pushed the fix/designer-edits branch from 25258d8 to 2cfcf2d Compare April 9, 2019 19:17
ceolson01
ceolson01 commented Apr 9, 2019
View reviewed changes
gatsby-config.js
langConfig: {
langs: CONFIGURED_LOCALES,
defaultLangKey,
prefixDefaultLangKey,
}
},
projects: ['colonyTutorials'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding projects fixes a regression bug introduced by a bad rebase.

rdig
rdig approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🎉

src/modules/pages/components/Developers/OpenSourceItem/OpenSourceItem.module.css Outdated
margin-bottom: -7px;
margin-top: -4px;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line here

@ceolson01 ceolson01 merged commit 7c25e46 into master Apr 10, 2019
@ceolson01 ceolson01 deleted the fix/designer-edits branch April 10, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

Assignees

@ceolson01 ceolson01

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceolson01 @rdig