This repository has been archived by the owner on Jun 12, 2022. It is now read-only.
Add support for not-hardcoded flags #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the luau submodule conflict? It seems that your PR is changing the submodule commit |
|
Should be fixed now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our discussion in #12 this PR adds support for flags that are not hardcoded into
luau-analyze-rojo.--flag:FlagName=valuenow.boolandintflags are supported. I think these are the only flag types.luau-analyze-rojowill check for and fail if you use an invalid flag. This can be disabled particularly for automated workflows since flags may change often and a flag being removed typically won't cause problems. For users it's typically a better experience to warn when an invalid flag has been entered.luau-analyze-rojo --show-flags