fix: don't set prefix for li element outside list #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wcalandro Happy to merge this, since the output seems like a better solution if the list item has no Thanks for contributing and let me know if you find anything else. Wow, this Probably with a different constructed HTML that contains an There is definitely room for performance improvements in quite a few parts of the library. And I should definitely add some benchmarks and fuzzing. Wonder what other inputs might cause a problem... |
AnastasiaShemyakinskaya
pushed a commit
to anyproto/html-to-markdown
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal fuzzer found that this package would timeout when handling the following testcase: testcase-timeout.txt. It appears to be caused by the assumption that, if a
<li>doesn't have a<ul>as a parent, the parent must be a<ol>. However, with malformed HTML this may not be the case. This issue is remedied by also checking if the parent is a<ol>, and if the parent is neither a<ul>nor a<ol>returning no list prefix.