Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Updated readme: NetCore and VS information, added disclaimer for the UncaughtReference error. #98

Merged
merged 14 commits into from
Oct 4, 2019

Conversation

SeppPenner
Copy link
Contributor

@SeppPenner SeppPenner commented Sep 30, 2019

Fixes #94, fixes #93, makes #95 redundant.

This pull request updates the information regarding requirements for Visual Studio and .NetCore and adds additional information on two commonly known issues: The Chart not drawn on client-side blazor in .netcore 3.0 from #93 and the Uncaught reference error from #94.

@Joelius300
Copy link
Owner

What do we want to do about the prerequisites? For this repo you don't need the preview for Visual Studio since we don't have client-side blazor in it. For the original repo you will need the preview AND you'll need .NET Core 3 preview 9 as well since client-side blazor is not available in .NET Core 3.0.

I think we should adjust it to how it's currently (.NET Core 3.0 and Visual Studio 2019 16.3) but keep the other things I said in mind for the original repo.

@Joelius300
Copy link
Owner

Do you approve these changes to your PR @SeppPenner?

@SeppPenner
Copy link
Contributor Author

I think we should adjust it to how it's currently (.NET Core 3.0 and Visual Studio 2019 16.3) but keep the other things I said in mind for the original repo.

Yeah, that's a good idea.

@Joelius300
Copy link
Owner

I guess that's an approval :) I'll merge it.

@Joelius300 Joelius300 merged commit dbf30e5 into Joelius300:master Oct 4, 2019
@Joelius300
Copy link
Owner

The commit history of this PR is pretty bad for some reason. Maybe we should've organized it first but since it was squashed it's not a problem in master. I will leave it like this.

@SeppPenner
Copy link
Contributor Author

The commit history of this PR is pretty bad for some reason.

I have seen that, but I have actually no idea why...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError Chart not drawn on client-side blazor in .netcore 3.0
2 participants