-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
From #84 (comment):
|
Fixes #85 as well. |
Still a few things missing:
Instead of writing
This is also part of what I meant by The summaries of many properties need to be rewritten or adjusted.
You missed my point. When we specify a value, anything other than null, the property will be set in js. If we set a null value (or nothing which implicitly sets null for reference types) the corresponding js-property will be undefined. If a js-property is undefined in a chart.js construct, the default option will be used by chart.js. This means that if we manually set Also something we should continue doing is marking these enums as |
Should be all done. |
I don't understand what's going on with Otherwise it looks good 👍 |
Do you mean like this: 4613133? |
Yes exactly :) I'll look over it in detail now and if I don't find any bigger issues, which I couldn't quickly resolve myself, I'll merge it soon (hopefully, I'm in class). |
I have finished working on this and could merge this now. However I cannot push my commit mqttnettest:special-enums :/ I get a 403.. do you maybe need to add me as a colaborator @SeppPenner ? |
Oh, sorry. Yes, you're added now. |
Nice 👍 |
Fixes #9, Fixes #41.