Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ARM64 support #54

Merged
merged 5 commits into from
Jul 2, 2022
Merged

Windows ARM64 support #54

merged 5 commits into from
Jul 2, 2022

Conversation

ZacWalk
Copy link
Contributor

@ZacWalk ZacWalk commented Jun 24, 2022

This PR adds Windows on ARM64 support.

The code changes are based on the approach Chromium took. I have run tests on my Surface ProX (ARM64 machine) and everything looked good. I also created VS2022 project files for testing.

@equalman
Copy link

equalman commented Jun 24, 2022 via email

@JochenKalmbach
Copy link
Owner

Thanks for your PR!
Can you add the environment to the appveyor build pipeline?
==> https://github.com/JochenKalmbach/StackWalker/blob/master/appveyor.yml

@ZacWalk
Copy link
Contributor Author

ZacWalk commented Jun 28, 2022

@JochenKalmbach how does that look? Took a few attempts but I got VS 2022 building it for ARM64 on appveyor.

@JochenKalmbach JochenKalmbach merged commit 5b0df7a into JochenKalmbach:master Jul 2, 2022
@ZacWalk
Copy link
Contributor Author

ZacWalk commented Jul 4, 2022

Thanks Jochen (y)

fengjixuchui added a commit to fengjixuchui/StackWalker that referenced this pull request Oct 18, 2022
Merge pull request JochenKalmbach#54 from ZacWalk/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants