Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a test file for mean_stdv (extractFormants) #81

Merged
merged 23 commits into from
Oct 10, 2022

Conversation

DerMoehre
Copy link
Contributor

It is the test file for the current solution in your code.

Is there a way, how I can choose the files for the PR? It always wants to add these 5 files and not just the test_
If so, I will revert this PR and do it again. Maybe it comes from the mess before

@JoFrhwld
Copy link
Owner

@DerMoehre I think I'd like to add some additional test cases here to reflect how I think mean_stdv() ought to work with relation to the rest of the code. If it's ok with you, I'll fetch your branch, add those cases in, then send you a pull request. After you merge that, those changes should wind up in this PR.

@chrisbrickhouse the test cases I'm going to add will fail even after we fix up the github actions. I'm adding these specifically to drive the refactor of mean_stdv

@DerMoehre
Copy link
Contributor Author

@JoFrhwld okay :) I never did a PR but it sounds good :)
After you added some more test cases, I will try to modify the main code to use numpy.

@JoFrhwld JoFrhwld merged commit 5983ed6 into JoFrhwld:dev Oct 10, 2022
@DerMoehre
Copy link
Contributor Author

Now that I merged your PR in the repository, what should I do next? :-D
Merge it again with a PR to dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants