Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #4

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Small fixes #4

merged 2 commits into from
Nov 19, 2022

Conversation

BenHenning
Copy link

@BenHenning BenHenning commented Nov 19, 2022 •
edited
Loading

This fixes a few things I found for oppia#4699, including:

  • An issue where the spotlight library would overwrite Oppia Android's app name (required a fix in the library & using the new version)
  • One missing KDoc in SpotlightManager
  • A regex failure in ExplorationActivityPresenter
  • Some dead code in SpotlightFragment
  • Fixes in ExplorationActivityTest
  • Fixes in SpotlightFragmentTest (fixed broken test by ensuring SpotlightFragment causes the anchor view to redraw to ensure doOnPreDraw is actually called)
  • Some fixes in TopicFragmentTest
  • One fix for instrumentation test builds

At this point, I think all checks will pass once the changes are merged.

@BenHenning
Fix broken test.
15eb671 
To ensure doOnPreDraw actually runs, we need to request that the view
gets re-drawn.
@BenHenning
Fix variety of issues.
2b92e62
@BenHenning
Copy link
Author

PTAL @JishnuGoyal

@JishnuGoyal JishnuGoyal marked this pull request as ready for review November 19, 2022 18:02
@JishnuGoyal JishnuGoyal merged commit 4703d44 into JishnuGoyal:add_all_spotlights_using_custom_queue Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenHenning @JishnuGoyal