refactor: clean up TCP and UDP serving #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Apr 14, 2023
fortuna
commented
Apr 14, 2023
jyyi1
approved these changes
Apr 17, 2023
service/tcp.go
Outdated
| ciphers: ciphers, | ||
| m: m, | ||
| readTimeout: timeout, | ||
| replayCache: replayCache, | ||
| targetIPValidator: onet.RequirePublicIP, | ||
| } | ||
| }) |
There was a problem hiding this comment.
nit why do we wrap the tcpHandler in brackets () here?
service/udp.go
Outdated
| } | ||
|
|
||
| func (s *udpService) SetTargetIPValidator(targetIPValidator onet.TargetIPValidator) { | ||
| func (s *packetHandler) SetTargetIPValidator(targetIPValidator onet.TargetIPValidator) { |
There was a problem hiding this comment.
nit maybe use p (stands for packetHandler) instead of s (stands for udpService)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the serving logic a lot simpler. Serve() was already tied to the listener lifetime, so now that's explicit, and closing the listener is the way to stop serving. We no longer need the complicated mutex logic.
This introduces a
StreamListenerconcept that can return any type of StreamConn, allowing for listening on Unix sockets or introduce intermediate transports (e.g. Websockets). We no longer require TCP.The handler will allow for easier replacement of the protocol in the future. That also makes it easier to test.