Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Commit

Permalink
fix(windows): fix AWS CLI exit code 255 in GitHub action (#179)
Browse files Browse the repository at this point in the history
Use the official way to configure AWS credentials instead of raw environment variables as recommended here: aws/aws-cli#5262 (comment). Because GitHub action cannot run `aws s3` successfully due to unknown `AWS_EC2_METADATA` or region issues.
  • Loading branch information
jyyi1 authored Apr 26, 2022
1 parent 3fd3dda commit bc225d6
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/upload_windows_client_to_s3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,14 @@ jobs:
- name: Checkout repo
uses: actions/checkout@v1

- name: Install AWS CLI
run: |
sudo apt-get install -y awscli
aws --version
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
aws-region: us-east-1
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

- name: Upload Windows Client to S3
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
run: |
declare -a FILES=(
"Outline-Client.exe"
Expand Down

0 comments on commit bc225d6

Please sign in to comment.