Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with current "New Repository Overview" experiment on GitHub #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jord1e
Copy link

@jord1e jord1e commented Oct 25, 2023

Hi 👋

This implements support for the (currently) experimental "New Repository Overview" feature on GitHub.

Fixes: https://youtrack.jetbrains.com/issue/TBX-9862/JetBrains-Toolbox-Extension-doesnt-work-properly-on-new-github-naviagtion

Info: https://github.com/orgs/community/discussions/61982


Current plugin:

With (old repository overview)

image

New Repository View (current plugin version):

image


Plugin disabled for reference:
image


With my changes applied:

image

With my changes applied & experiment disabled, as you can see current behaviour is still the same:

image

@jord1e
Copy link
Author

jord1e commented Oct 25, 2023

PR also correct again:

image

Please note that it has incorrect padding with https://github.com/refined-github/refined-github, but that's on them to figure out, this accommodates the default GitHub experience

@maximmig
Copy link
Contributor

Sorry for the late reply, but this PR seems outdated, sorry.

Copy link

@MrFiregore MrFiregore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must to change the line 28 of github.js to this

const BLOB_HEADER_BUTTON_GROUP_SCC_SELECTOR = "#repo-content-pjax-container div:has(> div.react-directory-add-file-icon)";

With this change it will works on public github

UPDATE : This only add open file buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants