Yarn pnp support #345
Merged
Yarn pnp support #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Module or symbolModule This change fixes module not found errors that could occur when specifying a custom spriteModule or symbolModule. Previously the import statements this loader generated would only work for svg imports made from certain directories.
This change makes the default values for spriteModule and symbolModule use absolute paths so that they work with yarn plug n play ISSUES CLOSED: 344
|
@bimbiltu huge thanks for your PR, released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
bugfix
What is the current behavior? (You can also link to an open issue here)
#344
What is the new behavior (if this is a feature change)?
This change makes the loader compatible with yarn plug n play
Does this PR introduce a breaking change?
No
Please check if the PR fulfills contributing guidelines
Yes it does