Skip to content

Commit

Permalink
Fcs/module reader: remove some excessive logging
Browse files Browse the repository at this point in the history
  • Loading branch information
auduchinok committed Feb 3, 2025
1 parent d2e9c27 commit fe8035d
Showing 1 changed file with 2 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,7 @@ public static void CheckAndThrow()
}
else
{
{
try
{
Interruption.Current.CheckAndThrow();
}
catch (Exception e) when (e.IsOperationCanceled())
{
var logger = Logger.GetLogger(typeof(FSharpAsyncUtil));
logger.Trace("Cancelled via Interruption.Current.CheckAndThrow()");
throw;
}
}

Interruption.Current.CheckAndThrow();
}
}

Expand Down Expand Up @@ -92,11 +80,11 @@ public static void UsingReadLockInsideFcs(IShellLocks locks, Action action)
{
logger.Trace("UsingReadLockInsideFcs: exception: the operation cancelled on the initial thread");

// todo: what if this happens in F#->C#->F#?
if (locks.IsReadAccessAllowed())
{
// The FCS request has originated from a R# thread and was cancelled. We don't want to requeue this request.
// If the request is coming from FCS, it's cancelled below in the loop.
// We could also check `Cancellable.HasCancellationToken` instead.
logger.Trace("UsingReadLockInsideFcs: read lock was acquired before the request, rethrowing");
throw;
}
Expand Down

0 comments on commit fe8035d

Please sign in to comment.