Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add limited Windows agents support (for self-hosted runners only) #31

Merged
merged 2 commits into from
Jan 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,19 @@ jobs:
npm install
- run: |
npm run all
test: # make sure the action works on a clean machine without building
test-ubuntu: # make sure the action works on a clean machine without building
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: ./
with:
linter: jetbrains/qodana-js

# Not possible at the moment for GitHub-hosted Windows agents: https://github.com/JetBrains/qodana-action/pull/31#issue-812728409
# test-windows:
# runs-on: windows-latest
# steps:
# - uses: actions/checkout@v2
# - uses: ./
# with:
# linter: jetbrains/qodana-js
5 changes: 2 additions & 3 deletions __tests__/main.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ function defaultDockerRunCommandFixture(): string[] {
return [
'run',
'--rm',
'-u',
`${process.getuid()}:${process.getgid()}`,
'-e',
'CI=GITHUB',
'-v',
Expand All @@ -98,6 +96,8 @@ function defaultDockerRunCommandFixture(): string[] {
'${{ github.workspace }}:/data/project',
'-v',
'${{ runner.temp }}/qodana-results:/data/results',
'-u',
`${process.getuid()}:${process.getgid()}`,
'jetbrains/qodana-jvm-community',
'--save-report'
]
Expand All @@ -124,6 +124,5 @@ test('test sarif with no problems to output annotations', () => {
test('input validation', () => {
const inputs = inputsDefaultFixture()
inputs.linter = 'jetbrains/qodana-clone-finder'
// expect the exception
expect(() => validateContext(inputs)).toThrow()
})
12 changes: 7 additions & 5 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

Loading