implement About the conference screen #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsmb13
requested changes
Jan 18, 2025
shared/src/commonMain/composeResources/drawable/kotlinconf_by_jetbrains.xml
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/jetbrains/kotlinconf/screens/AboutConference.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/jetbrains/kotlinconf/screens/AboutConference.kt
Outdated
Show resolved
Hide resolved
ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt
Outdated
Show resolved
Hide resolved
ui-components/src/commonMain/kotlin/org/jetbrains/kotlinconf/ui/components/DayHeader.kt
Show resolved
Hide resolved
zsmb13
approved these changes
Jan 22, 2025
e5l
approved these changes
Jan 22, 2025
| AboutConference( | ||
| onPrivacyPolicy = { navController.navigate(PrivacyPolicyForVisitorsScreen) }, | ||
| onGeneralTerms = { navController.navigate(TermsOfUseScreen) }, | ||
| onWebsiteLink = { urlHandler.openUri("https://kotlinconf.com/") }, |
| Column( | ||
| verticalArrangement = Arrangement.spacedBy(48.dp), | ||
| ) { | ||
| // TODO retrieve data from the service |
There was a problem hiding this comment.
please log an issue and link it in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screen is ready except the data is not yet there, I filled the schedule with placeholder text