-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
group-and-fold implementation #1004
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6da367
KEEP-23 implement group and fold operations
ilya-g 16bff4c
Tests for group-and-fold operations
ilya-g 3327c35
Minor refactoring: use mapValuesInPlace optimization, delegate aggreg…
ilya-g fed11aa
Rename Grouping.elementIterator to sourceIterator
ilya-g e7d9b79
Improve docs, use consistent naming for parameters, rename unused par…
ilya-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7630,6 +7630,18 @@ public inline fun <K, V, M : MutableMap<in K, MutableList<V>>> CharArray.groupBy | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from an array to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Array<out T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each element in the original array. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1179,6 +1179,18 @@ public inline fun <T, K, V, M : MutableMap<in K, MutableList<V>>> Iterable<T>.gr | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a collection to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Iterable<T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each element in the original collection. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -644,6 +644,18 @@ public inline fun <T, K, V, M : MutableMap<in K, MutableList<V>>> Sequence<T>.gr | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a sequence to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Sequence<T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a sequence containing the results of applying the given [transform] function | ||
* to each element in the original sequence. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -701,6 +701,18 @@ public inline fun <K, V, M : MutableMap<in K, MutableList<V>>> CharSequence.grou | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a char sequence to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each character. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <K> CharSequence.groupingBy(crossinline keySelector: (Char) -> K): Grouping<Char, K> { | ||
return object : Grouping<Char, K> { | ||
override fun sourceIterator(): Iterator<Char> = [email protected]() | ||
override fun keyOf(element: Char): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each character in the original char sequence. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright 2010-2016 JetBrains s.r.o. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package kotlin.collections | ||
|
||
/** | ||
* Groups elements from the [Grouping] source by key and counts elements in each group. | ||
* | ||
* @return a [Map] associating the key of each group with the count of element in the group. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public fun <T, K> Grouping<T, K>.eachCount(): Map<K, Int> = | ||
fold(0) { acc, e -> acc + 1 } | ||
|
||
/** | ||
* Groups elements from the [Grouping] source by key and sums values provided by the [valueSelector] function for elements in each group. | ||
* | ||
* @return a [Map] associating the key of each group with the count of element in the group. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Grouping<T, K>.eachSumOf(valueSelector: (T) -> Int): Map<K, Int> = | ||
fold(0) { acc, e -> acc + valueSelector(e) } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7713,6 +7713,18 @@ public inline fun <K, V, M : MutableMap<in K, MutableList<V>>> CharArray.groupBy | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from an array to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Array<out T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each element in the original array. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1190,6 +1190,18 @@ public inline fun <T, K, V, M : MutableMap<in K, MutableList<V>>> Iterable<T>.gr | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a collection to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Iterable<T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each element in the original collection. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -663,6 +663,18 @@ public inline fun <T, K, V, M : MutableMap<in K, MutableList<V>>> Sequence<T>.gr | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a sequence to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each element. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <T, K> Sequence<T>.groupingBy(crossinline keySelector: (T) -> K): Grouping<T, K> { | ||
return object : Grouping<T, K> { | ||
override fun sourceIterator(): Iterator<T> = [email protected]() | ||
override fun keyOf(element: T): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a sequence containing the results of applying the given [transform] function | ||
* to each element in the original sequence. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -710,6 +710,18 @@ public inline fun <K, V, M : MutableMap<in K, MutableList<V>>> CharSequence.grou | |
return destination | ||
} | ||
|
||
/** | ||
* Creates a [Grouping] source from a char sequence to be used later with one of group-and-fold operations | ||
* using the specified [keySelector] function to extract a key from each character. | ||
*/ | ||
@SinceKotlin("1.1") | ||
public inline fun <K> CharSequence.groupingBy(crossinline keySelector: (Char) -> K): Grouping<Char, K> { | ||
return object : Grouping<Char, K> { | ||
override fun sourceIterator(): Iterator<Char> = [email protected]() | ||
override fun keyOf(element: Char): K = keySelector(element) | ||
} | ||
} | ||
|
||
/** | ||
* Returns a list containing the results of applying the given [transform] function | ||
* to each character in the original char sequence. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there is specialization here? the implementations look the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's how the code is generated now.