-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JS IR] Throw exception if test class or test method has explicit par…
…ameter resolves https://youtrack.jetbrains.com/issue/KT-41032
- Loading branch information
Showing
6 changed files
with
273 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
js/js.tests/test/org/jetbrains/kotlin/js/test/es6/semantics/IrBoxJsES6TestGenerated.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
5 changes: 5 additions & 0 deletions
5
js/js.tests/test/org/jetbrains/kotlin/js/test/ir/semantics/IrBoxJsTestGenerated.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
5 changes: 5 additions & 0 deletions
5
js/js.tests/test/org/jetbrains/kotlin/js/test/semantics/BoxJsTestGenerated.java
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
196 changes: 196 additions & 0 deletions
196
js/js.translator/testData/box/kotlin.test/illegalParameters.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,196 @@ | ||
| // IGNORE_BACKEND: JS | ||
| // KJS_WITH_FULL_RUNTIME | ||
| // SKIP_DCE_DRIVEN | ||
|
|
||
| import common.* | ||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertTrue | ||
|
|
||
| class BadClass(id: Int) { | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| private class BadPrivateClass { | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| class BadProtectedMethodClass { | ||
| @Test | ||
| protected fun foo() {} | ||
| } | ||
|
|
||
| class BadPrimaryGoodSecondary(private val id: Int) { | ||
| constructor(): this(3) | ||
| @Test | ||
| fun foo() { | ||
| assertEquals(id, 3) | ||
| } | ||
| } | ||
|
|
||
| class GoodSecondaryOnly { | ||
| constructor() { | ||
| triggered = 3 | ||
| } | ||
| constructor(id: Int) { | ||
| triggered = id | ||
| } | ||
| companion object { | ||
| private var triggered = 0 | ||
| } | ||
| @Test | ||
| fun foo() { | ||
| assertEquals(triggered, 3) | ||
| } | ||
| } | ||
|
|
||
| class BadSecondaryOnly { | ||
| private constructor() {} | ||
| constructor(id: Int) {} | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| class BadConstructorClass private constructor() { | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| class BadProtectedConstructorClass protected constructor() { | ||
| constructor(flag: Boolean): this() | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| class GoodClass() { | ||
| constructor(id: Int): this() | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
|
|
||
| class GoodNestedClass { | ||
| class NestedTestClass { | ||
| @Test | ||
| fun foo() {} | ||
|
|
||
| fun helperMethod(param: String) {} | ||
| } | ||
| } | ||
|
|
||
| class BadNestedClass { | ||
| class NestedTestClass(id: Int) { | ||
| @Test | ||
| fun foo() {} | ||
| } | ||
| } | ||
|
|
||
| class BadMethodClass() { | ||
| @Test | ||
| fun foo(id: Int) {} | ||
|
|
||
| @Test | ||
| private fun ping() {} | ||
| } | ||
|
|
||
| // non-reachable scenarios are tested in nested.kt | ||
| class OuterWithPrivateCompanion { | ||
| private companion object { | ||
| object InnerCompanion { | ||
| @Test | ||
| fun innerCompanionTest() { | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| class OuterWithPrivateMethod { | ||
| companion object { | ||
| object InnerCompanion { | ||
| @Test | ||
| private fun innerCompanionTest() { | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fun box() = checkLog { | ||
| suite("BadClass") { | ||
| test("foo") { | ||
| caught("Test class BadClass must declare a public or internal constructor with no explicit parameters") | ||
| } | ||
| } | ||
| suite("BadPrivateClass") { | ||
| test("foo") { | ||
| caught("Test method BadPrivateClass::foo should have public or internal visibility, can not have parameters") | ||
| } | ||
| } | ||
| suite("BadProtectedMethodClass") { | ||
| test("foo") { | ||
| caught("Test method BadProtectedMethodClass::foo should have public or internal visibility, can not have parameters") | ||
| } | ||
| } | ||
| suite("BadPrimaryGoodSecondary") { | ||
| test("foo") | ||
| } | ||
| suite("GoodSecondaryOnly") { | ||
| test("foo") | ||
| } | ||
| suite("BadSecondaryOnly") { | ||
| test("foo") { | ||
| caught("Test class BadSecondaryOnly must declare a public or internal constructor with no explicit parameters") | ||
| } | ||
| } | ||
| suite("BadConstructorClass") { | ||
| test("foo") { | ||
| caught("Test class BadConstructorClass must declare a public or internal constructor with no explicit parameters") | ||
| } | ||
| } | ||
| suite("BadProtectedConstructorClass") { | ||
| test("foo") { | ||
| caught("Test class BadProtectedConstructorClass must declare a public or internal constructor with no explicit parameters") | ||
| } | ||
| } | ||
| suite("GoodClass") { | ||
| test("foo") | ||
| } | ||
| suite("GoodNestedClass") { | ||
| suite("NestedTestClass") { | ||
| test("foo") | ||
| } | ||
| } | ||
| suite("BadNestedClass") { | ||
| suite("NestedTestClass") { | ||
| test("foo") { | ||
| caught("Test class BadNestedClass.NestedTestClass must declare a public or internal constructor with no explicit parameters") | ||
| } | ||
| } | ||
| } | ||
| suite("BadMethodClass") { | ||
| test("foo") { | ||
| caught("Test method BadMethodClass::foo should have public or internal visibility, can not have parameters") | ||
| } | ||
| test("ping") { | ||
| caught("Test method BadMethodClass::ping should have public or internal visibility, can not have parameters") | ||
| } | ||
| } | ||
| suite("OuterWithPrivateCompanion") { | ||
| suite("Companion") { | ||
| suite("InnerCompanion") { | ||
| test("innerCompanionTest") { | ||
| caught("Test method OuterWithPrivateCompanion.Companion.InnerCompanion::innerCompanionTest should have public or internal visibility, can not have parameters") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| suite("OuterWithPrivateMethod") { | ||
| suite("Companion") { | ||
| suite("InnerCompanion") { | ||
| test("innerCompanionTest") { | ||
| caught("Test method OuterWithPrivateMethod.Companion.InnerCompanion::innerCompanionTest should have public or internal visibility, can not have parameters") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.