Skip to content

Commit

Permalink
[Gradle][MPP] MPP/AGP compatibility: Bump maxSupportedVersion to 7.3
Browse files Browse the repository at this point in the history
^KT-54071 Verification Pending
  • Loading branch information
sellmair authored and Space committed Sep 19, 2022
1 parent def886c commit 2ba7c7b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,8 @@ open class KotlinAndroid71GradleIT : KotlinAndroid70GradleIT() {
// Special version added for testing KT-49798
.plus(AGPVersion.fromString("7.1.0-beta02"))
.filter { version -> version >= AGPVersion.v4_2_0 }
// Current Gradle version within kotlin.git is not sufficient to build with higher AGP
.filter { version -> version < AGPVersion.v7_2_2 }

checkedConsumerAGPVersions.forEach { agpVersion ->

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface TestVersions {
const val AGP_70 = "7.0.4"
const val AGP_71 = "7.1.3"
const val AGP_72 = "7.2.1"
const val AGP_73 = "7.3.0"

const val MIN_SUPPORTED = AGP_36 // KotlinAndroidPlugin.MINIMAL_SUPPORTED_AGP_VERSION
const val MAX_SUPPORTED = AGP_70 // Update once Gradle MAX_SUPPORTED version will be bumped to 7.2+
Expand All @@ -58,6 +59,7 @@ interface TestVersions {
AGP_70(AGP.AGP_70, GradleVersion.version(Gradle.G_7_0), GradleVersion.version(Gradle.G_7_4), JavaVersion.VERSION_11),
AGP_71(AGP.AGP_71, GradleVersion.version(Gradle.G_7_2), GradleVersion.version(Gradle.G_7_4), JavaVersion.VERSION_11),
AGP_72(AGP.AGP_72, GradleVersion.version(Gradle.G_7_3), GradleVersion.version(Gradle.G_7_4), JavaVersion.VERSION_11),
AGP_73(AGP.AGP_73, GradleVersion.version(Gradle.G_7_4), GradleVersion.version(Gradle.G_7_5), JavaVersion.VERSION_11),
;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ class AGPVersion private constructor(private val versionNumber: VersionNumber) {
val v4_2_0 = fromString("4.2.2")
val v7_0_0 = fromString("7.0.4")
val v7_1_0 = fromString("7.1.2")
val v7_2_2 = fromString("7.2.2")
val v7_3_0 = fromString("7.3.0")

val testedVersions = listOf(v3_6_0, v4_1_0, v4_2_0, v7_0_0, v7_1_0)
val testedVersions = listOf(v3_6_0, v4_1_0, v4_2_0, v7_0_0, v7_1_0, v7_2_2, v7_3_0)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal object KotlinMultiplatformAndroidGradlePluginCompatibilityHealthCheck {

val compatibleAndroidGradlePluginVersionRange = AndroidGradlePluginVersionRange(
minSupportedVersion = AndroidGradlePluginVersion(4, 0),
maxSupportedVersion = AndroidGradlePluginVersion(7, 2)
maxSupportedVersion = AndroidGradlePluginVersion(7, 3)
)

/**
Expand Down

0 comments on commit 2ba7c7b

Please sign in to comment.