Mimalloc allocator integration #3704

LepilkinaElena · 2019-12-19T14:07:41Z

No description provided.

build-tools/src/main/kotlin/org/jetbrains/kotlin/CompileCToBitcode.kt

runtime/build.gradle

runtime/src/opt_alloc/cpp/AllocImpl.cpp

runtime/src/mimalloc/c/alloc-override.c

runtime/src/mimalloc/c/include/mimalloc-atomic.h

runtime/src/mimalloc/c/alloc-aligned.c

build-tools/src/main/kotlin/org/jetbrains/kotlin/CompileToBitcode.kt

runtime/build.gradle

runtime/src/mimalloc/c/include/mimalloc-internal.h

sbogolepov · 2019-12-24T06:13:27Z

shared/src/main/kotlin/org/jetbrains/kotlin/konan/target/KonanTargetExtenstions.kt

+        this == KonanTarget.IOS_X64
+
+fun KonanTarget.supportsOptimizedAllocator(): Boolean =


supportsOptimizedAllocator is a bit unclear. Maybe supportsMimallocAllocatior?

I don't want to connect this with exact allocator, there is possibility that we change or add another one.

The problem is that the set of supported targets is determined by allocator itself, not target. The set for jemalloc or any other allocator may be different.
Another possible solution is to add enum of alternative allocators and its entry to supportsOptimizedAllocator.

Another good thing is to describe why other targets are not supported.

Yes, it's a good idea with enum, but now it would be strange to have enumeration with one allocator. I don't want to show name of allocator in compiler options. Now we have just std and opt. It seems that same names everywhere are better.

build-tools/src/main/kotlin/org/jetbrains/kotlin/CompileToBitcode.kt

sbogolepov · 2019-12-24T06:40:23Z

build-tools/src/main/kotlin/org/jetbrains/kotlin/CompileToBitcode.kt

+        val (executable, defaultFlags, srcFilesPatterns) =
+                if (language == Language.C)
+                    Triple("clang",
+                    commonFlags + listOf("-std=gnu11", "-O3", "-Wall", "-Wextra", "-Wno-unknown-pragmas",


Why -O3 for C and -O2 for C++? Also why there is no -fPIC here?

I tried to save options that are set in build scripts for allocator, it's already tuned. I thought about -fPIC, and I understood it wasn't used because of some assembly parts for some platforms. Assembly code isn't written in proper way for position independent code.
If you see real problems with this I need to turn on and test again all platforms it influences.

It would be easier to update versions if we save settings, because there are some hacks to speed up allocator.

I tried to save options that are set in build scripts for allocator, it's already tuned.

Then it is better to mention it with a comment.

If you see real problems with this I need to turn on and test again all platforms it influences.

There was an Android target that wasn't compiling because of -fPIC absence, but I don't remember which one :)

I built some projects with native Android, if we meet a problem then will be a time to decide. I think without exact use case it's better to save default options set.

backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/KonanConfig.kt

backend.native/cli.bc/src/org/jetbrains/kotlin/cli/bc/K2Native.kt

sbogolepov · 2019-12-24T08:57:29Z

backend.native/tests/build.gradle

@@ -317,8 +317,8 @@ def createTestTasks(File testRoot, Class<Task> taskType, Closure taskConfigurati

 void dependsOnPlatformLibs(Task t) {
    if (!useCustomDist) {
-        def testTarget = project.testTarget
-        if (testTarget != null && testTarget != project.hostName) {
+        def testTarget = project.target


Why this change is needed?

It was for running raspberry-pi tests. @PavelPunegov should commit sane changes on master.

sbogolepov · 2019-12-25T11:21:49Z

backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/KonanConfig.kt

+        if (configuration.get(KonanConfigKeys.ALLOCATION_MODE) == "mimalloc") {
+            if (!target.supportsMimallocAllocator()) {
+                configuration.report(CompilerMessageSeverity.STRONG_WARNING,
+                        "Optimized allocation mode isn't supported on target ${target.name}. Used standard mode.")


Optimized allocation mode -> "mimalloc allocator".