This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Update LLVM to 6.0.1 and WebAssembly target refactoring #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
reviewed
Jul 10, 2018
konan/konan.properties
Outdated
| @@ -54,7 +54,7 @@ osVersionMin.macos_x64 = 10.11 | |||
| entrySelector.macos_x64 = -alias _Konan_main _main | |||
| dependencies.macos_x64 = \ | |||
| libffi-3.2.1-2-darwin-macos \ | |||
| clang-llvm-5.0.0-darwin-macos | |||
| clang-llvm-6.0.0-darwin-macos | |||
olonho
reviewed
Jul 10, 2018
konan/platforms/zephyr/stm32f4_disco
Outdated
| target-sysroot-2-wasm | ||
|
|
||
| targetToolchain.mingw_x64-zephyr_stm32f4_disco = gcc-arm-none-eabi-7-2017-q4-major-win32/arm-none-eabi | ||
| dependencies.mingw_x64-zephyr_stm32f4_disco = \ | ||
| msys2-mingw-w64-x86_64-gcc-7.2.0-clang-llvm-5.0.0-windows-x86-64 \ | ||
| mingw64 \ |
There was a problem hiding this comment.
Execution failed for task ':dependencies:gcc-arm-none-eabi-7-2017-q4-major-win32'.
> org.jetbrains.kotlin.konan.util.DependencyDownloader$HTTPResponseException: Server returned HTTP response code: 403 for URL: https://cache-redirector.jetbrains.com/download.jetbrains.com/kotlin/native/mingw64.zip
There was a problem hiding this comment.
@msink, it's not ready for use yet :)
olonho
reviewed
Jul 10, 2018
runtime/src/main/cpp/math/fmodf.cpp
Outdated
| @@ -1,6 +1,10 @@ | |||
| #include <math.h> | |||
| #include <stdint.h> | |||
|
|
|||
| #ifdef KONAN_WASM | |||
| #include "../Common.h" | |||
There was a problem hiding this comment.
Please don't use includes by relative paths.
Also add RUNTIME_USED in separate ifdef, code is unreadable this way.
sbogolepov
changed the title
sbogolepov
force-pushed
the
llvm6
branch
2 times, most recently
from
d30a0b3
to
7ecdc2b
Compare
sbogolepov
force-pushed
the
llvm6
branch
2 times, most recently
from
edbd0bd
to
84d1b5a
Compare
sbogolepov
changed the title
olonho
approved these changes
Aug 14, 2018
olonho
approved these changes
Aug 14, 2018
|
@viteinfinite this PR has nothing to do with bitcode embedding. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly improvements: