Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotNullByDefault #105

Merged
merged 1 commit into from
Sep 27, 2024
Merged

NotNullByDefault #105

merged 1 commit into from
Sep 27, 2024

Conversation

amaembo
Copy link
Collaborator

@amaembo amaembo commented May 17, 2024

I wanted to add a 'MODULE' target as well, but this would require separate Java 8 and Java 9 versions which will complicate the build, especially taking into account the necessity to support a Kotlin version as well. Let's postpone this.

Not sure about whether it should support newly declared type parameter bounds. Like if we declare class Foo<T> under @NotNullByDefault, should we assume that it's class Foo<T extends @NotNull Object> (that is: cannot be instantiated by a nullable type)? Note that if the class contains a method like T get();, it's implicitly assumed that it's @NotNull T get();

@amaembo amaembo requested a review from chashnikov May 17, 2024 14:18
@cpovirk
Copy link

cpovirk commented Jul 16, 2024

Hi, Tagir! I wanted to give you a heads-up that we're planning to finally release JSpecify 1.0.0 tomorrow. That may or may not have any impact on what you plan to do with the JetBrains annotations, but I could understand how our long development time could make anyone reluctant to make JSpecify a significant part of your plans yet.

(Incidentally, here's what we've written about JSpecify support in Intellij and other tools. I should probably have some other specific links to pass along, but that's the main one I'm thinking of at the minute. Let me know (here, in the JSpecify issue tracker, or over email) if you can think of anything you'd like to know.)

@amaembo amaembo merged commit c6cf75b into master Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants