Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a 'MODULE' target as well, but this would require separate Java 8 and Java 9 versions which will complicate the build, especially taking into account the necessity to support a Kotlin version as well. Let's postpone this.
Not sure about whether it should support newly declared type parameter bounds. Like if we declare
class Foo<T>
under@NotNullByDefault
, should we assume that it'sclass Foo<T extends @NotNull Object>
(that is: cannot be instantiated by a nullable type)? Note that if the class contains a method likeT get();
, it's implicitly assumed that it's@NotNull T get();