Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs-vika #1410

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

tabs-vika #1410

wants to merge 3 commits into from

Conversation

WildSeaTurtle
Copy link

No description provided.

Replaced outdated tab images with new, detailed examples, including dark theme variants, and archived the old images for reference. Enhanced the tab guidelines by restructuring sections, improving clarity, and adding visual examples to emphasize best practices.
@WildSeaTurtle WildSeaTurtle requested a review from OlyaB January 2, 2025 13:34
@WildSeaTurtle WildSeaTurtle self-assigned this Jan 2, 2025
@@ -10,10 +10,11 @@

</tldr>

Tabs organize content in dialogs by grouping similar UI controls.
Tabs organize content by grouping similar UI controls.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly replace the word "similar" with "related"?


## Tabs in Code Editors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly rename this to "Tab Control Implementations" and tell that this article covers tabs in dialogs but there are two other implementations? To make it more clear about which tabs this article is.

</td>
</tr>
</table>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add more mistakes to the Incorrect version? It appears under a paragraph with several rules but illustrates only one about Advanced.


Place the most frequently used content in the first tab.

Tabs that do not fit allotted screen space automatically hide under the dropdown component.
(It is better to add no more than 8 tabs, but this number is not limited.)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing the round brackets here, just leave the sentence without them.

</tr>
</table>

### Organization and Accessibility
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Accessibility" creates expectations that this part might tell something about voice-over, high contrast and other stuff usually associated with this word. Possibly make the header about tabs order?


<format color="Red" style="bold">Incorrect</format>
Always place tabs on top. It is possible to place them at other sides of the content — bottom, left, or right — but such a placement is extremely rare and might confuse users.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading the first time, had the question "on top of what?". Possibly write as "Always place tabs on top of the content", and remove "of the content" in the 2nd sentence.


<format color="Red" style="bold">Incorrect</format>
When there are other UI controls above tabs, separate them with a vertical indent.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence appears right under the "Incorrect" example, which makes the structure a bit unclear. Possibly add an inividual header for this sentence, e.g. "Controls above tabs"


When there are other UI controls above tabs, separate them with a vertical indent.
### Bottom border
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest calling this "Tabs border" because there's only one border in tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants