Support FontVariation.Settings in components.resources #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR can only run after compose version 1.8.0-alpha01. |
terrakok
reviewed
Dec 11, 2024
...nts/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/FontResources.kt
Show resolved
Hide resolved
MatkovIvan
reviewed
Dec 11, 2024
...rces/library/src/androidMain/kotlin/org/jetbrains/compose/resources/FontResources.android.kt
Show resolved
Hide resolved
This reverts commit 7fcf218.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Support FontVariation.Settings in components.resources
Fixes [link to the issue]
Testing
Should be manually tested.
Run on desktop via Gradle:
./gradlew :resources:demo:desktopApp:runRun JS in browser with WebAssembly Skia via Gradle:
./gradlew :resources:demo:shared:jsBrowserDevelopmentRunThis should be tested by QA
Release Notes
Subsections:
Section - Subsection