Support K2 mode in the IJ plugin #5138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
commented
Sep 14, 2024
| @@ -35,7 +32,7 @@ class PreviewStateService(private val myProject: Project) : Disposable { | |||
| init { | |||
| val projectRefreshListener = ConfigurePreviewTaskNameCacheInvalidator(configurePreviewTaskNameCache) | |||
| ExternalSystemProgressNotificationManager.getInstance() | |||
| .addNotificationListener(projectRefreshListener, myProject) | |||
| .addNotificationListener(projectRefreshListener, this) | |||
There was a problem hiding this comment.
I'm not sure what is the expected behaviour here — the service was marked as an app-level service and the project used as disposable, but using Project as disposable is bad. It feels like the service should be project-level, so this subscription would maintain the same scope, but I don't know if it's the right way to go about it.
1. Migrate to IJP Gradle plugin 2.x 2. Upgrade Gradle to 8.10 3. Bump IJ target to 2024.2.1 4. Clean up after migration
This makes the IJ plugin run in K2 mode with the new Analysis APIs, instead of the old K1 APIs.
kropp
force-pushed
the
support-k2-mode
branch
from
1d1af33 to
42f31bd
Compare
kropp
approved these changes
Nov 7, 2024
kropp
pushed a commit
that referenced
this pull request
Dec 12, 2024
This PR makes the IJ plugin run in K2 mode with the new Analysis APIs, instead of the old K1 APIs. It also includes cleaning up a bunch of compiler warnings, and some mistakes I saw when migrating to K2. --------- Co-authored-by: Victor Kropp <[email protected]> (cherry picked from commit 1b877dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the IJ plugin run in K2 mode with the new Analysis APIs, instead of the old K1 APIs. It also includes cleaning up a bunch of compiler warnings, and some mistakes I saw when migrating to K2.
I have tested it on my own machine and it seems to work, both in IJ 243 EAP1 and 242.1, but I'd recommend you try it out too. Also, I don't have any Compose Web-based project to test the related changes with.
Important
Requires #5137 to be merged first.
Release Notes
Features - Desktop