Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kotlin 1.9.20-Beta2 #3721

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Support kotlin 1.9.20-Beta2 #3721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposeCompilerCompatibility.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ internal object ComposeCompilerCompatibility {
"1.9.0-RC" to "1.4.8-beta",
"1.9.0" to "1.5.1",
"1.9.10" to "1.5.2",
"1.9.20-Beta" to "1.5.2.1-Beta2"
"1.9.20-Beta" to "1.5.2.1-Beta2",
"1.9.20-Beta2" to "1.5.2.1-Beta3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should name compiler versions the same as we name main compose versions (-beta01, -beta02)

)

fun compilerVersionFor(kotlinVersion: String): String {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a failed test. Does it fail before the change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check.
This change doesn't affect the version of the plugin used in the tests. So it's likely a flaky test/environemnt.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerun helped :|

Expand Down