-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to notarytool for notarization #3642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pjBooms
approved these changes
Sep 8, 2023
.../src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractNotarizationTask.kt
Outdated
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Sep 8, 2023
Otherwise all builds fail
AlexeyTsvetkov
force-pushed
the
notarytool
branch
from
September 19, 2023 14:02
e079fe7
to
356161c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from using
altool
which has been deprecated in favor ofnotarytool
Also, now the plugin waits for the notarization process to finish, and staples the package automatically after that.
Now it is mandatory to specify
teamID
for notarization. The team ID can be passed using thecompose.desktop.mac.notarization.teamID
Gradle property:Alternatively, the notarization settings can also be set using the DSL.
For example, it is possible to pass credentials using environment variables:
The
compose.desktop.application.macOS.notarization.ascProvider
DSL property andcompose.desktop.mac.notarization.ascProvider
Gradle property are now removed (theteamID
property should be used instead).The password for notarization cannot be passed using
@keychain:PATH_TO_KEYCHAIN_LOCATION
anymore.The
checkNotarizationStatus
task is removed, since now the plugin waits for notarization to finish.Additional information
Resolves #3208
Resolves #2253
The PR is based on the #3330 by @DRSchlaubi