Add uikit to experimental/examples/imageviewer #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dima-avdeev-jb
commented
Dec 22, 2022
•
dima-avdeev-jb
commented
- Add miniatures for big images. It speeds up launch.
- Move most of the Desktop and Android code to commonMain.
- Add UIKit target. For now, bitmap filters don't work for UIKIt.
…it-to-imageviewer
dima-avdeev-jb
commented
Dec 22, 2022
| @@ -0,0 +1,7 @@ | |||
| package example.imageviewer.model | |||
|
|
|||
| const val BASE_URL = "https://raw.githubusercontent.com/JetBrains/compose-jb/master/artwork/imageviewerrepo" | |||
There was a problem hiding this comment.
For now, If you want to run sample, change the url to:
"https://raw.githubusercontent.com/JetBrains/compose-jb/dima-avdeev/add-uikit-to-imageviewer/artwork/imageviewerrepo"
igordmn
approved these changes
Dec 22, 2022
| val imageSize = IntSize(imageWithFilter.width, imageWithFilter.height) | ||
| val scalableState = remember(imageSize) { mutableStateOf(ScalableState(imageSize)) } | ||
| val visiblePartOfImage: IntRect = scalableState.value.visiblePart | ||
| Slider( |
There was a problem hiding this comment.
The slider and Back/Forward colors don't fit into imageviewer theme:
Let's change them to something else (more grayish probably, not sure)
Co-authored-by: Igor Demin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.