Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ProGuard integration for Compose/Desktop packaging #2313

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Introduce ProGuard integration for Compose/Desktop packaging #2313

merged 1 commit into from
Sep 14, 2022

Conversation

AlexeyTsvetkov
Copy link
Collaborator

Resolves #1174

dima-avdeev-jb
dima-avdeev-jb reviewed Sep 14, 2022
View reviewed changes
.../src/main/kotlin/org/jetbrains/compose/desktop/application/internal/JvmApplicationContext.kt Show resolved Hide resolved
...ose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/JvmApplicationData.kt Show resolved Hide resolved
...src/main/kotlin/org/jetbrains/compose/desktop/application/internal/JvmApplicationInternal.kt Outdated Show resolved Hide resolved
...pose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/MultiOutputStream.kt Outdated Show resolved Hide resolved
...pose/src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractProguardTask.kt Show resolved Hide resolved
...pose/src/main/kotlin/org/jetbrains/compose/desktop/application/tasks/AbstractProguardTask.kt Show resolved Hide resolved
gradle-plugins/compose/src/test/kotlin/org/jetbrains/compose/gradle/DesktopApplicationTest.kt Show resolved Hide resolved
@AlexeyTsvetkov AlexeyTsvetkov merged commit d9de125 into master Sep 14, 2022
@AlexeyTsvetkov AlexeyTsvetkov deleted the proguard branch September 14, 2022 15:23
@dima-avdeev-jb
Copy link
Contributor

All good, Thanks!

@StefanOltmann
Copy link

Really awesome that you did this! 🥇

@natanfudge
Copy link

natanfudge commented Oct 11, 2022 •
edited
Loading

Why proguard over R8? R8 has Kotlin-specific optimizations that should work for the desktop JVM as well. R8 is especially significant in Compose, as the performance is quite poor without R8.

@russellbanks
Copy link

Why proguard over R8? R8 has Kotlin-specific optimizations that should work for the desktop JVM as well. R8 is especially significant in Compose, as the performance is quite poor without R8.

There is a blog by Guardsquare (they make Proguard so bare that in mind) that highlights the differences between the two tools: https://www.guardsquare.com/blog/proguard-and-r8

From the blog:

Comparing performance of the optimizations at build time is tricky, since ProGuard and R8 have somewhat different purposes. ProGuard reads and writes Java bytecode. R8 primarily reads Java bytecode and writes Dalvik bytecode -- writing Java bytecode is not functional yet.

From this, it appears that R8 is oriented a lot towards Android as it is intended for the Dalvik Virtual Machine whereas Proguard is intended for the Java Virtual Machine.

@mrjameshamilton mrjameshamilton mentioned this pull request Oct 19, 2022
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima-avdeev-jb dima-avdeev-jb dima-avdeev-jb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to use ProGuard with Compose for Desktop
5 participants
@AlexeyTsvetkov @dima-avdeev-jb @StefanOltmann @natanfudge @russellbanks