Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKitView has white space at the top in latest dev build #4095

Closed
SebastianAigner opened this issue Jan 3, 2024 · 5 comments · Fixed by JetBrains/compose-multiplatform-core#986
Labels
bug Something isn't working ios p:high High priority reproduced

Comments

@SebastianAigner
Copy link
Member

SebastianAigner commented Jan 3, 2024

My UIKitView looks fine with 1.5.x and 1.6.0-alpha01, but in 1.6.0-dev1357 gets a weird white border at the top. Tested this with web views, video views (AVKit), video views (VLCKit) – all the same result:

IMG_0080

@SebastianAigner SebastianAigner added bug Something isn't working submitted labels Jan 3, 2024
@eymar
Copy link
Member

eymar commented Jan 4, 2024

Hi Sebastian!
I'm trying to reproduce the issue. I tried with a mapview and webview. But they don't have a white border.

Is there something I need to consider?
Maybe a specific iOS version? Did you run on iPhone or iPad maybe? (the view seem to be in a lanscape mode)
Some particular Modifiers?

Do you have this project on github?

@eymar eymar added wait for reply Further information is requested and removed submitted labels Jan 4, 2024
@SebastianAigner
Copy link
Member Author

SebastianAigner commented Jan 8, 2024

Hi @eymar! You can check out https://github.com/SebastianAigner/reelchest/tree/dev-version-update/mobileapp to observe the issue.

Start the app and click "Go directly to TikTok". The white bar at the top is not visible in the alpha release, only in dev. I've tried it on the latest iPad Pro emulator as well as on a physical device.

Screenshot 2024-01-08 at 23 48 22

You can also click "Go to WM" and open the "web" application.

@SebastianAigner SebastianAigner removed the wait for reply Further information is requested label Jan 8, 2024
@eymar
Copy link
Member

eymar commented Jan 9, 2024

Thanks!
Reproduceable starting from 1.6.0-dev1347.
in 1.6.0-dev1340 no issue.
Suspect one of the commits on 19 of Dec 2023 - https://github.com/JetBrains/compose-multiplatform-core/commits/jb-main

@eymar eymar added reproduced p:high High priority labels Jan 9, 2024
@MatkovIvan MatkovIvan added the ios label Jan 9, 2024
@eymar
Copy link
Member

eymar commented Jan 9, 2024

git besect shows that it started to show extra white space after this change JetBrains/compose-multiplatform-core@b42dfe4

MatkovIvan added a commit to JetBrains/compose-multiplatform-core that referenced this issue Jan 11, 2024
## Proposed Changes

- Use root coordinates for interop instead of window ones - it's
different after #956

## Testing

Test: run app from the issue or open "UIKitViewMatryoshka" in mpp

Before | After
---|---
![Simulator Screenshot - iPhone 15 Pro - 2024-01-11 at 13 00
20](https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/0035c206-1f1c-40d6-a59a-f6f3c9d01617)
| ![Simulator Screenshot - iPhone 15 Pro - 2024-01-11 at 13 06
04](https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/cf679f2a-0c35-41c2-ac1a-66c18feced8c)



## Issues Fixed

Fixes JetBrains/compose-multiplatform#4095
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ios p:high High priority reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants