Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify 'runtime-saveable' targets to match 'runtime' #3899

Closed
JakeWharton opened this issue Nov 3, 2023 · 1 comment · Fixed by JetBrains/compose-multiplatform-core#894
Closed

Unify 'runtime-saveable' targets to match 'runtime' #3899

JakeWharton opened this issue Nov 3, 2023 · 1 comment · Fixed by JetBrains/compose-multiplatform-core#894
Assignees
@eymar
Labels
enhancement New feature or request infrastructure runtime Compose runtime problem

Comments

@JakeWharton
Copy link

These should be published using the same targets. Right now 'runtime-saveable' is missing a bunch that 'runtime' supports'.
@JakeWharton JakeWharton added enhancement New feature or request submitted labels Nov 3, 2023
@JakeWharton JakeWharton mentioned this issue Nov 3, 2023
Merged
@igordmn igordmn added infrastructure runtime Compose runtime problem and removed submitted labels Nov 8, 2023
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Nov 9, 2023
@JakeWharton
Unify runtime-saveable's targets with the runtime (#894)
b82f26d 
It supports more targets than the general compose multiplatform
libraries, and the two should be unified.

Test: gw :compose:runtime:runtime-saveable:watchosArm64Binaries
:compose:runtime:runtime-saveable:watchosArm32Binaries
:compose:runtime:runtime-saveable:watchosX86Binaries
:compose:runtime:runtime-saveable:watchosX64Binaries
:compose:runtime:runtime-saveable:watchosSimulatorArm64Binaries
:compose:runtime:runtime-saveable:tvosArm64Binaries
:compose:runtime:runtime-saveable:tvosX64Binaries
:compose:runtime:runtime-saveable:tvosSimulatorArm64Binaries
:compose:runtime:runtime-saveable:mingwX64Binaries
:compose:runtime:runtime-saveable:linuxX64Binaries

Closes JetBrains/compose-multiplatform#3899
mazunin-v-jb pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Dec 7, 2023
@JakeWharton @mazunin-v-jb
Unify runtime-saveable's targets with the runtime (#894)
468a545 
It supports more targets than the general compose multiplatform
libraries, and the two should be unified.

Test: gw :compose:runtime:runtime-saveable:watchosArm64Binaries
:compose:runtime:runtime-saveable:watchosArm32Binaries
:compose:runtime:runtime-saveable:watchosX86Binaries
:compose:runtime:runtime-saveable:watchosX64Binaries
:compose:runtime:runtime-saveable:watchosSimulatorArm64Binaries
:compose:runtime:runtime-saveable:tvosArm64Binaries
:compose:runtime:runtime-saveable:tvosX64Binaries
:compose:runtime:runtime-saveable:tvosSimulatorArm64Binaries
:compose:runtime:runtime-saveable:mingwX64Binaries
:compose:runtime:runtime-saveable:linuxX64Binaries

Closes JetBrains/compose-multiplatform#3899
This was referenced Jan 25, 2024
Closed
Closed
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eymar eymar

Labels
enhancement New feature or request infrastructure runtime Compose runtime problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify runtime-saveable's targets with the runtime JakeWharton/compose-multiplatform-core
4 participants
@JakeWharton @igordmn @eymar @okushnikov