-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ComposePanel.windowContainer
public
#992
Conversation
Can you explain a bit why it needs to be public? |
If I am not mistaken, It is needed for a case, when some small ComposePanel tries to show a popup/dialog outside of the panel. In this case, users should set Worth to add an example. Also, we need to change the description, so it can be included in the changelog and outside user can understand what the feature is about. And change the KDoc |
4563aec
to
7c91c2f
Compare
ComposePanel.layersContainer
publicComposePanel.windowContainer
public
6eea06c
to
d7b9f28
Compare
d7b9f28
to
87379de
Compare
Proposed Changes
ComposePanel.windowContainer
to customize behavior of additional layers (Popup/Dialog)Testing
Test: try to use this API with
compose.layers.type=COMPONENT
windowContainer
windowContainer