Caret behavior by single tap in Cupertino textfields #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyled textfield. Forwarded callback for showing context menu (should be called by tap on the caret)
MatkovIvan
reviewed
Oct 2, 2023
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Oct 2, 2023
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Oct 5, 2023
...skikoMain/kotlin/androidx/compose/foundation/text/CupertionTextFieldPointerModifier.skiko.kt
Show resolved
Hide resolved
| currentState.processor, | ||
| currentOffsetMapping, | ||
| currentState.onValueChange | ||
| TextFieldDelegate.cupertinoSetCursorOffsetFocused( |
There was a problem hiding this comment.
Do we have an ability to move cursor to the middle of a word?
As in iOS native apps:
(or differently for now).
If we don't have that, we should postpone merging this PR, otherwise we'll block the ability to move the cursor to the middle
There was a problem hiding this comment.
Here it is
#913
@MatkovIvan maybe you want to look at it too
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
…into separate method and create enum class - in purpose to make it testable
MatkovIvan
requested changes
Nov 13, 2023
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
… handling to ui-text, changed logic of caret behavior, added tests
MatkovIvan
reviewed
Nov 22, 2023
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Nov 22, 2023
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
…n, removed changes in public API (ui-text), refactor logic in TextFieldDelegate.skiko.kt, added documentation to some supplementary functions
MatkovIvan
reviewed
Nov 23, 2023
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Nov 29, 2023
MatkovIvan
reviewed
Nov 29, 2023
...tion/foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/StringHelpers.skiko.kt
Show resolved
Hide resolved
...tion/foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/StringHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
...tion/foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/StringHelpers.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/skikoMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.skiko.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Dec 6, 2023
mazunin-v-jb
deleted the
v.mazunin/dev/single-tap-native-behavior-in-cupertino-textfield
branch
mazunin-v-jb
added a commit
that referenced
this pull request
Dec 7, 2023
## Proposed Changes - Split behavior for focused and unfocused state, like in native applications. - Added behavior logic for focused state of text field. - Forwarded callback for showing context menu actions by tap on the caret. ## Testing Test: Run App, open Components - TextField - Almost Fullscreen. Try cases described in the documentation of `cupertinoSetCursorOffsetFocused() ` ## Issues Fixed https://youtrack.jetbrains.com/issue/COMPOSE-445/iOS-adjust-caret-behavior-in-textfields-for-single-tap ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Run App, open Components - TextField - Almost Fullscreen. Try cases described in the documentation of
cupertinoSetCursorOffsetFocused()Issues Fixed
https://youtrack.jetbrains.com/issue/COMPOSE-445/iOS-adjust-caret-behavior-in-textfields-for-single-tap
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.