Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS UIKit interop regression fix #857

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

elijah-semyonov
Copy link

Proposed Changes

Bind UIKitInteropContext to AttachedComposeContext lifetime, flush all pending UIKitInteropActions when AttachedComposeContext is closed.

Testing

Test: check that there are no black screens for interop UIImageViews in Demo/NativeModalWithNavigation

Issues Fixed

Fixes: invalid UIKit view hierarchy when scene is disposed after navigating from ComposeUIViewController sourcing it.

RPReplay_Final1696253384.MP4

@elijah-semyonov elijah-semyonov merged commit 7bc20a9 into jb-main Oct 4, 2023
@elijah-semyonov elijah-semyonov deleted the es/interop-regression-fix branch October 4, 2023 11:02
mazunin-v-jb pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black screens with UIKitView after navigating away and navigating back on 1.5.10-beta02
2 participants