Fix accessibility not reporting changes #842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sun.lwawt.macosx.CAccessible
does this weird thing:So unless the
Accessible
is an instance ofjava.awt.Component
, it will not register its property change listener with its accessible context. This prevents us from notifying it when a value changes (a progress bar updates for example).Proposed Changes
Make
ComposeAccessible
a subclass ofjava.awt.Component
.This also requires renaming its
accessibleContext
property, becausejava.awt.Component
already has a protected field with the same name.Testing
Test: Can't test this without exposing something about the amount of property change listeners registered with
ComposeAccessibleComponent
. Tested manually with a progress bar (needs a bit of additional code, which I'll add in the next PR).