Implementation of defaultTimePickerLayoutType #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Composable getters still don't compile for JS? |
MatkovIvan
reviewed
Sep 19, 2023
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TimePicker.kt
Show resolved
Hide resolved
|
BTW, this can be commonized too. There is already a getScreenHeight function. If there'd be the same function for width or just one for size @Composable
@ReadOnlyComposable
internal expect fun getScreenSize() : DpSizethen aspect ratio condition can be written in common |
MatkovIvan
approved these changes
Sep 21, 2023
igordmn
approved these changes
Sep 21, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
## Proposed Changes Implementation of `defaultTimePickerLayoutType` with the new `WindowInfo` api. Copy of the [Android](https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/TimePicker.android.kt) implementation. ## Testing Test: display timepicker with different window aspect ratio
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
#817) ## Proposed Changes Implementation of `defaultTimePickerLayoutType` with the new `WindowInfo` api. Copy of the [Android](https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/TimePicker.android.kt) implementation. ## Testing Test: display timepicker with different window aspect ratio
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
## Proposed Changes Implementation of `defaultTimePickerLayoutType` with the new `WindowInfo` api. Copy of the [Android](https://github.com/JetBrains/compose-multiplatform-core/blob/jb-main/compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/TimePicker.android.kt) implementation. ## Testing Test: display timepicker with different window aspect ratio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implementation of
defaultTimePickerLayoutTypewith the newWindowInfoapi.Copy of the Android implementation.
Testing
Test: display timepicker with different window aspect ratio