Implement PlatformLocale and StringDelegate for k/wasm (#561) #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag`
igordmn
reviewed
Jul 7, 2023
| } | ||
| } | ||
|
|
||
| internal actual fun PlatformLocale.isRtl(): Boolean = false // TODO | ||
|
|
||
| private val rtlLanguagesSet = setOf("ar", "fa", "he", "iw", "ji", "ur", "yi") |
There was a problem hiding this comment.
What is the source of this? Can we add a link in a comment?
This list has more RTL languages
There was a problem hiding this comment.
As far as I remember it's from sources of function that we call on java target
There was a problem hiding this comment.
That's right. I added a comment.
It was taken from here https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/ComponentOrientation.java#L156 to follow the desktop impl.
igordmn
approved these changes
Jul 7, 2023
MatkovIvan
approved these changes
Jul 10, 2023
eymar
commented
Jul 10, 2023
compose/ui/ui-text/src/jsWasmMain/kotlin/androidx/compose/ui/text/intl/JsPlatformLocale.js.kt
Outdated
Show resolved
Hide resolved
Walingar
pushed a commit
to Walingar/androidx
that referenced
this pull request
Jul 11, 2023
JetBrains#625) * Implement PlatformLocale and StringDelegate for k/wasm (JetBrains#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
mazunin-v-jb
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Implement PlatformLocale and StringDelegate for k/wasm (#561) * Workaround `isOnUiThread` (ui-test) for k/wasm browser target * Implement PlatformLocale and StringDelegate for k/wasm * Get rid of expect/actuals for jsWasmMain and use js(...) for a common implementation * use the list of preferred languages - `window.navigator.languages` * delete unused fun `currentLanguageTag` * Add a comment
eymar
pushed a commit
that referenced
this pull request
Dec 18, 2023
Please see [b/204328129](https://issuetracker.google.com/issues/204328129) for more details on the issue. Basically this is something necessary to help prevent weird compilation errors that happen with the Buck/Redex build toolchains that Meta uses. Not something meaningful, but since the change is dead simple I guess it shall pass. Test: This has been something that was patched on Meta source and we've been testing it for multiple prod releases of Threads, we're only now porting the change to Google because it seems appropriate. Fixes: b/204328129 This is an imported pull request from androidx#625. Resolves #625 Github-Pr-Head-Sha: 0568741 GitOrigin-RevId: 023a53d Change-Id: I5b3fe39e54ffd4f97234c0ff23e54f9b790b2f0f
igordmn
pushed a commit
that referenced
this pull request
Dec 20, 2023
Please see [b/204328129](https://issuetracker.google.com/issues/204328129) for more details on the issue. Basically this is something necessary to help prevent weird compilation errors that happen with the Buck/Redex build toolchains that Meta uses. Not something meaningful, but since the change is dead simple I guess it shall pass. Test: This has been something that was patched on Meta source and we've been testing it for multiple prod releases of Threads, we're only now porting the change to Google because it seems appropriate. Fixes: b/204328129 This is an imported pull request from androidx#625. Resolves #625 Github-Pr-Head-Sha: 0568741 GitOrigin-RevId: 023a53d (cherry picked from https://android-review.googlesource.com/q/commit:ca6fa30821e365ed3976bbcd0202c38b9da2c842) Merged-In: I5b3fe39e54ffd4f97234c0ff23e54f9b790b2f0f Change-Id: I5b3fe39e54ffd4f97234c0ff23e54f9b790b2f0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "upstreams" #561 from wasm-main to jb-main