UIKitView. Fix lifetime discrepancy within the composition. #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
changed the title
elijah-semyonov
requested review from
mazunin-v-jb
and removed request for
dima-avdeev-jb
igordmn
approved these changes
Jun 6, 2023
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/interop/UIKitView.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Jun 7, 2023
igordmn
pushed a commit
that referenced
this pull request
Jul 10, 2023
Test: ./gradlew test connectedCheck Bug: 270612487 This is an imported pull request from androidx#576. Resolves #576 Github-Pr-Head-Sha: 2a52799 GitOrigin-RevId: 0cb474a Change-Id: I8bdb3a7b0a53cc47e20e1fecf8e4c3de78819bae
igordmn
changed the title
igordmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
factoryinvocation result.onValueChangedlambda.DisposableEffect, since relevantUIViewlifetime is already bound to composable function lifetime.onReleaselambda, addTarget doesn't retain target.Testing
Test: launch a repro from issued mentioned below
Issues Fixed
Fixes: Bug on JetBrains/compose-multiplatform#3119.
To clarify
Do we need to remember
onRelease?