Popup accessibility #439
Merged
Popup accessibility #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walingar
force-pushed
the
nr/popup-accessibility
branch
from
7e1c73d to
4852569
Compare
igordmn
reviewed
Mar 22, 2023
|
|
||
| internal class ComposeLayer( | ||
| private val skiaLayerAnalytics: SkiaLayerAnalytics | ||
| ) { | ||
| private var isDisposed = false | ||
|
|
||
| internal val sceneAccessible = ComposeSceneAccessible( |
There was a problem hiding this comment.
I will test only how it works (macOs, Windows) now later, and post the results here.
@m-sasha, could you do a full review?
There was a problem hiding this comment.
I checked it on MacOs and Windows (NVDA), it works fine.
m-sasha
requested changes
Mar 24, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindowDelegate.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/Accessibility.desktop.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/ApplicationAccessibilityTest.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/ApplicationAccessibilityTest.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/ApplicationAccessibilityTest.kt
Show resolved
Hide resolved
...se/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/ApplicationAccessibilityTest.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/ApplicationAccessibilityTest.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeLayer.desktop.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Mar 29, 2023
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/ComposeSceneAccessible.kt
Outdated
Show resolved
Hide resolved
…nFocusRequested for each context request
Now ComposeSceneAccessible handles accessibleAt(point) taking all skia owners into account
Walingar
force-pushed
the
nr/popup-accessibility
branch
from
dbbfb2e to
3b7fbf8
Compare
m-sasha
approved these changes
Apr 14, 2023
MatkovIvan
approved these changes
Apr 17, 2023
igordmn
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Extract ComposeSceneAccessible * Make ComposeSceneAccessible the main accessible wrapper for a Window Now ComposeSceneAccessible handles accessibleAt(point) taking all skia owners into account * Introduce test for accessibility in popups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Manual testing and newly introduced
ApplicationAccessibilityTestIssues Fixed
Fixes: JetBrains/compose-multiplatform#2041
Fixes: JetBrains/compose-multiplatform#2185
Fixes: JetBrains/compose-multiplatform#2120