Implement TextFieldScrollState and TextFieldScrollbarAdapter #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igordmn Ready for CR |
...dation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/v2/Scrollbar.desktop.kt
Outdated
Show resolved
Hide resolved
...foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/BasicTextField.desktop.kt
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Jan 26, 2023
igordmn
approved these changes
Jan 26, 2023
...n/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldScrollState.desktop.kt.kt
Outdated
Show resolved
Hide resolved
...n/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldScrollState.desktop.kt.kt
Outdated
Show resolved
Hide resolved
...n/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldScrollState.desktop.kt.kt
Outdated
Show resolved
Hide resolved
...n/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldScrollState.desktop.kt.kt
Outdated
Show resolved
Hide resolved
...foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/BasicTextField.desktop.kt
Show resolved
Hide resolved
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
…and TextFieldScrollbarAdapter (#384)
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
…crollState and TextFieldScrollbarAdapter (#384)
liusbl
added a commit
to liusbl/QuestLog
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In order to support scrollbars for text fields, we need to expose their scroll state and implement a ScrollbarAdapter for it.
TextFieldScrollStatewhich wraps the actual (internal) text field scroll state object:TextFieldScrollerPosition, in order to allow hoisting.BasicTextFieldoverloads that accept the new TextFieldScrollState. Unfortunately this means copy-pasting them from the upstream source. We will need to remember to update them whenever the upstream changes.TextFieldScrollerPositionparameter toCoreTextFieldso that our new BasicTextFields can unwrap and pass the wrapper scroller position to it.viewportSizeproperty to TextFieldScrollerPosition.Testing
Test: Unit and manual tests
Issues Fixed
Fixes: JetBrains/compose-multiplatform#1575