Fix crash when selecting a character before the punctuation sign #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
Feb 29, 2024
MatkovIvan
approved these changes
Feb 29, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Proposed Changes Fix OutOfBounds logical error leading to crash. Refactor testing of caret placement to be more apparent. ## Testing Test: CupertinoTextFieldDelegateTest.determineCursorDesiredOffset_tap_before_punctuation ## Issues Fixed Fixes: JetBrains/compose-multiplatform#4388 ## Note This PR fixes the crash, the behavior is still incorrect. Consult with code owner @mazunin-v-jb.
elijah-semyonov
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix OutOfBounds logical error leading to crash. Refactor testing of caret placement to be more apparent.
Testing
Test: CupertinoTextFieldDelegateTest.determineCursorDesiredOffset_tap_before_punctuation
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4388, crash in JetBrains/compose-multiplatform#4353
Note
This PR fixes the crash, the behavior is still incorrect. Consult with code owner @mazunin-v-jb.