iOS context menu isn't showing in empty textfield #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...skikoMain/kotlin/androidx/compose/foundation/text/CupertinoTextFieldPointerModifier.skiko.kt
Outdated
Show resolved
Hide resolved
…mpose/foundation/text/CupertinoTextFieldPointerModifier.skiko.kt change formatting Co-authored-by: dima.avdeev <[email protected]>
igordmn
approved these changes
Feb 26, 2024
igordmn
deleted the
v.mazunin/fix-ios-context-menu-in-empty-text-field
branch
igordmn
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Proposed Changes - forwarded calling the context menu to tap handling function in ios textfield ## Testing Test: Copy something to clipboard, open test app, go Components -> TextField -> Keyboard Actions, focus empty text field, tap on the caret ## Issues Fixed JetBrains/compose-multiplatform#4353 https://youtrack.jetbrains.com/issue/COMPOSE-1045/iOS-empty-textfield-context-menu ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well. --------- Co-authored-by: dima.avdeev <[email protected]> (cherry picked from commit db710ab)
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Proposed Changes - forwarded calling the context menu to tap handling function in ios textfield ## Testing Test: Copy something to clipboard, open test app, go Components -> TextField -> Keyboard Actions, focus empty text field, tap on the caret ## Issues Fixed JetBrains/compose-multiplatform#4353 https://youtrack.jetbrains.com/issue/COMPOSE-1045/iOS-empty-textfield-context-menu ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well. --------- Co-authored-by: dima.avdeev <[email protected]>
mazunin-v-jb
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes
Inability to open context menu in empty textfield by tapping on empty space or the caret, like native behavior.
Related issues:
JetBrains/compose-multiplatform#4353
https://youtrack.jetbrains.com/issue/COMPOSE-1045/iOS-empty-textfield-context-menu
Testing
Test: Copy something to clipboard, open test app, go Components -> TextField -> Keyboard Actions, focus empty text field, tap on the caret
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.