Reuse cached MTLCommandQueue across multiple MetalRedrawer's #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
changed the title
dima-avdeev-jb
approved these changes
Feb 21, 2024
MatkovIvan
reviewed
Feb 21, 2024
|
|
||
| private class CachedCommandQueue( | ||
| val queue: MTLCommandQueueProtocol, | ||
| var refCount: Int = 1 |
There was a problem hiding this comment.
Assumed to be used from the main thread.
| @@ -461,6 +464,46 @@ internal class MetalRedrawer( | |||
| companion object { | |||
| private val renderingDispatchQueue = | |||
| dispatch_queue_create("RenderingDispatchQueue", null) | |||
|
|
|||
| private class CachedCommandQueue( | |||
There was a problem hiding this comment.
I'd move it out from companion object and expose methods instead of public properties
MatkovIvan
reviewed
Feb 21, 2024
| * Get an existing command queue associated with the device or create a new one and cache it. | ||
| * Assumed to be run on the main thread. | ||
| */ | ||
| fun getCachedCommandQueue(device: MTLDeviceProtocol): MTLCommandQueueProtocol { |
There was a problem hiding this comment.
Might be private in current impl
MatkovIvan
approved these changes
Feb 21, 2024
igordmn
pushed a commit
that referenced
this pull request
Feb 21, 2024
## Proposed Changes `MTLCommandQueue` is not a transient object and internal pools of them can be starved. It leads to Metal being unable to allocate a new one when GC hasn't collected the previously created queues. Cache it for reuse purposes. ## Testing Test: N/A ## Issues Fixed Fixes: [COMPOSE-1022](https://youtrack.jetbrains.com/issue/COMPOSE-1022/)
igordmn
added
changelog: prerelease fix
elijah-semyonov
added a commit
to JetBrains/skiko
that referenced
this pull request
May 27, 2024
Speculative fix for [a case](JetBrains/compose-multiplatform#4761), where a lot of windows are created and dismissed. Caches command queue per device [similar to iOS](JetBrains/compose-multiplatform-core#1127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
MTLCommandQueueis not a transient object and internal pools of them can be starved. It leads to Metal being unable to allocate a new one when GC hasn't collected the previously created queues.Cache it for reuse purposes.
Testing
Test: N/A
Issues Fixed
Fixes: COMPOSE-1022