This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement buildTargetScalaMainClasses #36
Implement buildTargetScalaMainClasses #36
Changes from 7 commits
3dc670d
784c1bb
df5e842
e48a09b
017ef70
7622ec1
b1e0124
4c94579
127984b
dcb0882
7e1750b
b9d7637
2bac873
63c37e0
64bc27a
88e4eed
69728f0
fdc6cae
db9ea50
cc6214b
8815911
94c2441
bf55173
b41b805
5db976f
2b88327
b5bd604
7ae79f3
3f63924
d1b1e76
e0a6707
09443e5
8e23255
0089ae3
83a4f34
847d335
20b982d
8b801e3
0ce672b
f6d595d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it the same case as the two methods extracted below, that is, could it be extracted to something like getTargetOptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not exactly the same, two methods use getStringListValueList (because the attributes are of type string list) and one uses getStringValue.
Anyway, I extracted the methods with the same logic