Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

[feature] adding test package to JvmTestEnvironment data #309

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[feature] adding test package to JvmTestEnvironment data #309

merged 1 commit into from
Jan 26, 2023

Conversation

sellophane
Copy link
Contributor

No description provided.

@sellophane sellophane requested a review from abrams27 November 15, 2022 11:04
@tpasternak
Copy link
Contributor

IMO it would be cleaner to add a field in protocol, instead of a special-purpose environment variable

@sellophane
Copy link
Contributor Author

IMO it would be cleaner to add a field in protocol, instead of a special-purpose environment variable

build-server-protocol/build-server-protocol#380

@abrams27
Copy link
Member

hmmmmm, it's kinda hacky, maybe we can try to move stuff in the protocol

@sellophane sellophane force-pushed the binaries_lang branch 5 times, most recently from 3588f97 to 4e82489 Compare January 23, 2023 15:29
sellophane added a commit to sellophane/bazel-bsp that referenced this pull request Jan 23, 2023
@sellophane
[feature] add mainClasses parameters to JvmEnvironmentItem (JetBrains…
877ef91 
…#309)
@abrams27 abrams27 changed the title Adding test package to JvmTestEnvironment data [feature] adding test package to JvmTestEnvironment data Jan 25, 2023
@sellophane sellophane merged commit 01adba2 into JetBrains:master Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abrams27 abrams27 abrams27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sellophane @tpasternak @abrams27