This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
[feature] send notifications to client while junit5 testing #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60bb3e5
to
533b316
Compare
abrams27
suggested changes
Sep 26, 2022
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/ExecuteService.kt
Outdated
Show resolved
Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTaskNotifier.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
205dbe1
to
4814b6d
Compare
abrams27
suggested changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill take a look one more time tomorrow
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt
Outdated
Show resolved
Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt
Outdated
Show resolved
Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
server/src/test/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParserTest.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
abrams27
suggested changes
Sep 30, 2022
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/ExecuteService.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
ae9fbd9
to
bea8d83
Compare
abrams27
suggested changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just nitpicking + please update the changelog
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/ExecuteService.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt
Outdated
Show resolved
Hide resolved
lukaszwawrzyk
approved these changes
Oct 5, 2022
abrams27
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lets gooo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel-bsp
server now notifies the BSP client about events happening during testing with JUnit, including single tests and their results, as well as their hierarchy in test suitesCo-authored-by: azdrojowa123 [email protected]