Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

[feature] send notifications to client while junit5 testing #299

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

BlackAnubis7
Copy link
Contributor

bazel-bsp server now notifies the BSP client about events happening during testing with JUnit, including single tests and their results, as well as their hierarchy in test suites

Co-authored-by: azdrojowa123 [email protected]

@BlackAnubis7 BlackAnubis7 force-pushed the junit-pr branch 3 times, most recently from 205dbe1 to 4814b6d Compare September 29, 2022 12:52
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill take a look one more time tomorrow

@BlackAnubis7 BlackAnubis7 force-pushed the junit-pr branch 3 times, most recently from ae9fbd9 to bea8d83 Compare September 30, 2022 13:20
@abrams27 abrams27 changed the title [feature] send notifications to client while junit testing [feature] send notifications to client while junit5 testing Oct 3, 2022
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just nitpicking + please update the changelog

@abrams27 abrams27 requested a review from lukaszwawrzyk October 3, 2022 12:33
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lets gooo

@abrams27 abrams27 merged commit 7fcf9c0 into JetBrains:master Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants