This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[feature] Add CPP support #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdrojowa123
force-pushed
the
feature/cpp_support
branch
2 times, most recently
from
5ecfbf8 to
13b46e4
Compare
azdrojowa123
force-pushed
the
feature/cpp_support
branch
from
13b46e4 to
cbe0398
Compare
abrams27
suggested changes
Jul 22, 2022
There was a problem hiding this comment.
really good job! looks great, some nitpicking from my side
we dont want to commit all.log file - dunno why it was created
also, u need to fix the java formatting - we are using google java formatter (u can download the plugin), but sometimes there are some discrepancies between the plugin and the CI script - then u need to fix it manually : (
plus please update the description a bit and the changelog
plus please uncomment the cpp tests in ci - https://github.com/JetBrains/bazel-bsp/blob/master/.github/workflows/integration-tests.yml
e2e/src/main/java/org/jetbrains/bsp/bazel/BazelBspCppProjectTest.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppModule.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppModule.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppModule.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppLanguagePlugin.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppLanguagePlugin.kt
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/cpp/CppLanguagePlugin.kt
Outdated
Show resolved
Hide resolved
azdrojowa123
force-pushed
the
feature/cpp_support
branch
from
7f36869 to
23b4fc7
Compare
azdrojowa123
force-pushed
the
feature/cpp_support
branch
from
23b4fc7 to
83c50a0
Compare
abrams27
reviewed
Jul 22, 2022
|
@abrams27 merge is blocked due to this, is this issue still valid? #277 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement basic CPP support - still need to do some work e.g. with cpp compiler
https://youtrack.jetbrains.com/issue/BAZEL-25