This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[change] JvmEnvironmentItem is set using env from target
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 17, 2022 12:10
agluszak
suggested changes
Jun 20, 2022
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/java/JavaLanguagePlugin.java
Outdated
Show resolved
Hide resolved
agluszak
reviewed
Jun 20, 2022
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/proto/bsp_target_info.proto
Outdated
Show resolved
Hide resolved
abrams27
suggested changes
Jun 21, 2022
abrams27
suggested changes
Jul 5, 2022
e2e/src/main/java/org/jetbrains/bsp/bazel/BazelBspSampleRepoTest.kt
Outdated
Show resolved
Hide resolved
e2e/src/main/java/org/jetbrains/bsp/bazel/BazelBspSampleRepoTest.kt
Outdated
Show resolved
Hide resolved
e2e/src/main/java/org/jetbrains/bsp/bazel/BazelBspSampleRepoTest.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java
Outdated
Show resolved
Hide resolved
e2e/src/main/java/org/jetbrains/bsp/bazel/BazelBspSampleRepoTest.kt
Outdated
Show resolved
Hide resolved
added 8 commits
July 5, 2022 10:42
# Conflicts: # server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java # server/src/main/java/org/jetbrains/bsp/bazel/server/sync/IntelliJProjectTreeViewFix.java # server/src/main/java/org/jetbrains/bsp/bazel/server/sync/languages/java/JavaLanguagePlugin.java # server/src/main/java/org/jetbrains/bsp/bazel/server/sync/model/Module.java # server/src/test/java/org/jetbrains/bsp/bazel/server/bloop/BspModuleExporterTest.kt # server/src/test/java/org/jetbrains/bsp/bazel/server/sync/ProjectStorageTest.java
abrams27
suggested changes
Jul 11, 2022
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.kt
Outdated
Show resolved
Hide resolved
added 8 commits
July 11, 2022 15:34
abrams27
approved these changes
Jul 12, 2022
added 7 commits
July 13, 2022 11:51
# Conflicts: # CHANGELOG.md # server/src/main/java/org/jetbrains/bsp/bazel/server/sync/model/Module.kt
# Conflicts: # CHANGELOG.md
abrams27
changed the title
env from targetenv from target
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env in JvmEnvironmentItem should be set using env and env_inherit
https://youtrack.jetbrains.com/issue/BAZEL-90
bazel run //e2e:BazelBspSampleRepoTest